Merged
Conversation
Only assert cache-matched-key value when cache-hit is true, since transient S3 failures result in empty output by design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache-matched-keyoutput that reports the key of the cache entry that was found during restorecache-hitistrueandcache-matched-keyequals the inputkeyrestore-keysprefix match is found,cache-hitisfalsebutcache-matched-keyis set to the matching restore keycache-matched-keyis set to an empty string for consistency withcache-hitFixes #62
Changes
src/utils.ts: AddedsetCacheMatchedKeyOutputhelper functionsrc/restore.ts: CallsetCacheMatchedKeyOutputin all code paths (success, error, fallback)action.ymlandrestore/action.yml: Declare the newcache-matched-keyoutputREADME.md: Added usage example showingrestore-keyswithcache-matched-keydist/bundlesTest plan
cache-matched-keyto the primary keycache-matched-keyto the matching restore keycache-matched-keyto empty stringcache-matched-keyto the fallback matching key