Fix for triangular_solve BEF executable unit test failure on ROCm.#103
Open
rsanthanam-amd wants to merge 1 commit intotensorflow:masterfrom
Open
Fix for triangular_solve BEF executable unit test failure on ROCm.#103rsanthanam-amd wants to merge 1 commit intotensorflow:masterfrom
rsanthanam-amd wants to merge 1 commit intotensorflow:masterfrom
Conversation
Member
|
Nit: Could we please initialize a_num_elements to n * n? Something like: int32_t a_num_elements = n * n; Otherwise, looks good! :) |
rsanthanam-amd
force-pushed
the
rocm_triangular_solve_test_fix
branch
from
97c4c10 to
aa34cc0
Compare
Contributor
Author
Done. |
hanbinyoon
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @chsigg @hanbinyoon