Skip to content

Update LookingGlass.php#35

Open
sitepodmatt wants to merge 1 commit intotelephone:masterfrom
sitepodmatt:patch-1
Open

Update LookingGlass.php#35
sitepodmatt wants to merge 1 commit intotelephone:masterfrom
sitepodmatt:patch-1

Conversation

@sitepodmatt
Copy link

http prefix check is too generous allowing for http to appear anywhere

http prefix check is too generous allowing for http to appear anywhere
@jeteon
Copy link

jeteon commented Jan 13, 2017

Yeah. I think that line should be something more along the lines of:

if (stripos($url, 'http://') !== 0 && stripos($url, 'https://') !== 0) {
     // Make HTTP URL
}

It may not matter though since the host is extracted from the URL not long after the "HTTP" protocol part is added to it if deemed necessary by this check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants