Open
Conversation
choubacha
reviewed
Jan 20, 2022
| end | ||
|
|
||
| def parent_index_names | ||
| client.indices.get_alias(name: config_name).map { |k, v| k } |
There was a problem hiding this comment.
Suggested change
| client.indices.get_alias(name: config_name).map { |k, v| k } | |
| client.indices.get_alias(name: config_name).keys |
| def parent_index_names | ||
| client.indices.get_alias(name: config_name).map { |k, v| k } | ||
| rescue Elasticsearch::Transport::Transport::Errors::NotFound | ||
| nil |
There was a problem hiding this comment.
I'd rather return an empty array here and keep the return type consistent.
| end | ||
|
|
||
| if options['force_name'].present? | ||
| @force_name = options['force_name'] |
There was a problem hiding this comment.
Is there a reason to call this force_name versus alias_name?
Author
There was a problem hiding this comment.
Because an index name could also be used. It is an overwriting from the name on the config file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to migrate indexes with no downtime we need to be able to use aliases and to create indexes with custom names on ES. This PR adds the possibility of using custom names (outside of config) and adds methods to be able to get to the index reference (for creation and deletion) if using an alias.