Add FixedBuilderScore contract and deployment script#127
Merged
Conversation
ee777dc to
729daf6
Compare
RubenSousaDinis
previously approved these changes
Feb 4, 2026
Replace PassportBuilderScore with a dummy contract that returns a fixed score for all users. Admin can update the score via setFixedScore(). Includes deployment script that also updates TalentVault to use the new contract.
729daf6 to
c3dcdca
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| await talentVault.connect(user1).deposit(depositAmount, user1.address); | ||
|
|
||
| // Simulate time passing | ||
| ensureTimestamp(currentDateEpochSeconds + 31536000); // 1 year ahead |
There was a problem hiding this comment.
Missing await on async ensureTimestamp calls
Medium Severity
The ensureTimestamp function returns a Promise and needs to be awaited. Without await, the EVM timestamp may not be set before the subsequent refresh() call executes, causing the test to calculate rewards over an incorrect time period. Other usages in TalentRewardClaim.ts and the ensureTimeIsAfterLockPeriod helper function correctly use await.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Replace PassportBuilderScore with a dummy contract that returns a fixed score for all users. Admin can update the score via setFixedScore(). Includes deployment script that also updates TalentVault to use the new contract.
Note
Medium Risk
Impacts yield-rate inputs by enabling a single owner-updatable score source for all users, and includes a script that mutates mainnet
TalentVaultconfiguration; mistakes could change reward rates globally.Overview
Adds
FixedBuilderScore, a simpleOwnablecontract that returns a constant builder score for any passport ID and lets the owner update it viasetFixedScore(emittingFixedScoreUpdated).Introduces a mainnet/base-only Hardhat script (
deployFixedBuilderScore.ts) that deploysFixedBuilderScorewith an initial score (default60) and immediately updates the mainnetTalentVaultto use it viasetPassportBuilderScore. Tests and shared artifacts are extended to coverFixedBuilderScorebehavior and to validateTalentVaultyield tiering (base vs bonus) when swapping in the fixed-score implementation;.tool-versionsaddsyarn.Written by Cursor Bugbot for commit c3dcdca. This will update automatically on new commits. Configure here.