fix: vun Bypass on 30 days lock period#121
Open
developerfred wants to merge 1 commit intotalentprotocol:masterfrom
Open
fix: vun Bypass on 30 days lock period#121developerfred wants to merge 1 commit intotalentprotocol:masterfrom
developerfred wants to merge 1 commit intotalentprotocol:masterfrom
Conversation
Member
|
Hi @developerfred! Thanks for raising this issue with us! We confirm there's indeed an issue with the current contract as is. We will be deploying a new version of the Vault soon and the issue will be fixed there. |
Author
|
Thank you @RubenSousaDinis, I really like the talent protocol, so we need to mitigate any and all vulnerabilities that may be found. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a user can approve a third-party user they control to manage their shares, thus bypassing the 30-day lock and receiving tokens early.
This is a critical vulnerability; in this pull request, I fix it.
POC