Add --feature-requires flag for passing feature dependencies#292
Open
jcgruenhage wants to merge 1 commit intotaiki-e:mainfrom
Open
Add --feature-requires flag for passing feature dependencies#292jcgruenhage wants to merge 1 commit intotaiki-e:mainfrom
jcgruenhage wants to merge 1 commit intotaiki-e:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements what #264 asks for without splitting this into multiple commands. Theoretically this can replace
--group-features a,bby passing--feature-requires a:b,b:aand similarly it could be easily expanded to replace--mutually-exclusive-features a,bif we expanded the constraints to support negative dependencies--feature-requires a:!b,b:!a, but for now it's fully additional to those.I've chosen
winnowfor parsing, because we already depend on it through our toml parser.