perf: optimise cell reference parsing#623
Open
alexander-beedie wants to merge 1 commit intotafia:masterfrom
Open
perf: optimise cell reference parsing#623alexander-beedie wants to merge 1 commit intotafia:masterfrom
alexander-beedie wants to merge 1 commit intotafia:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Micro-optimisation
Slightly simpler/faster
get_row_and_optional_columnimplementation. Uses forward-accumulation (acc = acc * base + digit) instead of reverse-accumulation (acc += digit * pow; pow *= base). Saves a "multiply-and-store" per byte, and avoids the need for a state flag/branch (readrow).Performance
Marginal gains; it's fundamentally not an expensive function as cell references are tiny. Nevertheless, benchmarking on large sheets shows a consistent ~0.5-1.0% speedup as it's called so often.