refactor(cfb): resolve special case in the caller of fn get_chain#615
Merged
jmcnamara merged 1 commit intotafia:masterfrom Mar 7, 2026
Merged
refactor(cfb): resolve special case in the caller of fn get_chain#615jmcnamara merged 1 commit intotafia:masterfrom
jmcnamara merged 1 commit intotafia:masterfrom
Conversation
jmcnamara
reviewed
Mar 6, 2026
Contributor
Author
|
Ok, because the code now no longer has a reference to the spec justifying this change, reposting as comment |
Collaborator
|
Thanks for making the requested changes. Merged. |
jmcnamara
pushed a commit
that referenced
this pull request
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #609 where the confusion is resolved by
len == 0being caused by a special case in the spec.Resolving this special case in the caller streamlines the logic inside
fn get_chain