Draft
Conversation
rodolforg
requested changes
May 23, 2023
|
|
||
| // Same apply for C++ loops too | ||
|
|
||
| while (condition) { ... } |
Contributor
Author
There was a problem hiding this comment.
Wanted to keep the section topics minimal so I just lumped the below discussion in this portion too ;P
For consistency's sake, a new separate section would be much better. Updating the doc...
| // - Brace on the new line | ||
| // - And no space before function bracket | ||
|
|
||
| void my_function() |
Contributor
There was a problem hiding this comment.
Was defined we should keep this style below?
void
my_function()
{
}
Contributor
Author
There was a problem hiding this comment.
LOL the vote was 50-50 I didn't know what to choose without offending the other parties XD
Synfig and GTKMM code specifically tend to have lengthy return types so I voted your above style in the forum. Also, GTK dev team uses/recommends that in their codebase too.
I'll update the doc anyway... 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added them to Contributing guidelines section
Some of the topics I skipped where the vote was 50-50.Still more pending topics to add but I guess the initial draft is the best time when modification is less painful XD
All topics added to the best of my knowledge reading the forum.
Any criticisms are welcome.
Also since we are low in manpower I might mark this PR as ready to merge in July so it doesn't stay in draft mode forever.