Skip to content

BridgeJS: Remove adhoc exportedProtocolNameByKey recording #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krodak merged 1 commit into from
Jan 25, 2026
Merged

BridgeJS: Remove adhoc exportedProtocolNameByKey recording #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ public class ExportSwift {
private var exportedEnums: [ExportedEnum] = []
private var exportedStructs: [ExportedStruct] = []
private var exportedProtocols: [ExportedProtocol] = []
private var exportedProtocolNameByKey: [String: String] = [:]
private var typeDeclResolver: TypeDeclResolver = TypeDeclResolver()
private var sourceFiles: [(sourceFile: SourceFileSyntax, inputFilePath: String)] = []

Expand Down Expand Up @@ -1136,8 +1135,6 @@ public class ExportSwift {

stateStack.pop()

parent.exportedProtocolNameByKey[protocolUniqueKey] = name

return .skipChildren
}

Expand Down Expand Up @@ -1598,11 +1595,6 @@ public class ExportSwift {
return primitiveType
}

let protocolKey = typeName
if let protocolName = exportedProtocolNameByKey[protocolKey] {
return .swiftProtocol(protocolName)
}

guard let typeDecl = typeDeclResolver.resolve(type) else {
return nil
}
Expand Down
6 changes: 6 additions & 0 deletions Plugins/BridgeJS/Sources/BridgeJSCore/TypeDeclResolver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ class TypeDeclResolver {
override func visitPost(_ node: EnumDeclSyntax) {
visitPostNominalDecl()
}
override func visit(_ node: ProtocolDeclSyntax) -> SyntaxVisitorContinueKind {
return visitNominalDecl(node)
}
override func visitPost(_ node: ProtocolDeclSyntax) {
visitPostNominalDecl()
}

override func visit(_ node: TypeAliasDeclSyntax) -> SyntaxVisitorContinueKind {
let name = node.name.text
Expand Down