Closed
Conversation
zamderax
commented
Apr 17, 2025
zamderax
commented
- Adding POST and GET examples
- Adding easy examples for Codable, GET and POST to the Readme
Lukasa
requested changes
Apr 23, 2025
| import NIOCore | ||
| import NIOFoundationCompat | ||
|
|
||
| struct Comic: Codable{ |
Collaborator
There was a problem hiding this comment.
Suggested change
| struct Comic: Codable{ | |
| struct Comic: Codable { |
|
|
||
| static func getJSON() async throws { | ||
| let httpClient = HTTPClient(eventLoopGroupProvider: .singleton) | ||
| let car: Car = Car(make: "Toyota", model: "Camry", year: 2023) |
Collaborator
There was a problem hiding this comment.
This object is unused, and so this code snippet won't compile.
| request.headers.add(name: "Accept", value: "application/json") | ||
| request.method = .POST | ||
| request.body = .bytes(jsonData) | ||
| try await httpClient.shutdown() |
Collaborator
There was a problem hiding this comment.
This example doesn't send the request at all.
Author
|
Closing in favor of #829. I made the PR accidentally off the wrong branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.