Weather alert with container#26
Conversation
b876d86 to
33d90d6
Compare
OK, the PR is ready. Just for clarification, the PKEY I used was already decommissioned. I assume it must be a properly generated PKEY, but there is no need for it to be active. We now simply allow(client).to receive(:token) to avoid this issue, but it will be a landmine that future developers could step on. I've also added a fallback so the specs can run without |
83007b7 to
d851315
Compare
d851315 to
a599903
Compare
|
Thanks, I'll give it a spin in the next day or two so we can get this merged and released |
820d59b to
ab06731
Compare
This sounds like the sane thing to do here. Mocking isn't really a problem. |
The specs on the mock data were not doing what we'd expect, so I use the fixture data and make clear when we're testing a real payload. It's much easier to work with JSON as a separate file. I format the JSON with
jqfor readability.It may be better to have
Alert.WeatherAlertinstead ofWeatherAlert.Summarygiven that Summary is not the best way to describe everything.In this PR we also stifle errors from a bad PKEY and allow the specs to run without a
.envfile.