Update readme and add instructions for installation#1
Open
kinow wants to merge 6 commits intosuhanaser:masterfrom
Open
Update readme and add instructions for installation#1kinow wants to merge 6 commits intosuhanaser:masterfrom
kinow wants to merge 6 commits intosuhanaser:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for sharing
Rootstrap! This PR has the following:requirements.txtwith pinned versions (using a range with major.minor versions pinned, leaving patch to latest - semver.org, whenever possible)README.mdusing Markdown syntax for code block, withbashas the formatREADME.mdwith installation instructions withpipandcondarootstrap.pyand in a commentML_treeinrootstrap.pyNoneusingisinstead of==Using a virtual environment, and running
pip install -r requirements.txtafter the environment was activated, it installed the dependencies, and the following command worked—as far as I can tell—for me. Though I'm not much familiar with the theory behind it :)Dockerfileto easily use the script without installing the dependenciesI was going to add a
Dockerfiletoo, to make it easier to use the scripts without having to install dependencies, but ran out of time, sorry.Thanks!
Bruno