feat(isthmus): enable precision timestamp addition/subtraction#745
Merged
andrew-coleman merged 1 commit intosubstrait-io:mainfrom Mar 12, 2026
Merged
feat(isthmus): enable precision timestamp addition/subtraction#745andrew-coleman merged 1 commit intosubstrait-io:mainfrom
andrew-coleman merged 1 commit intosubstrait-io:mainfrom
Conversation
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
nielspardon
commented
Mar 11, 2026
| SqlStdOperatorTable.PLUS, Set.of("i8", "i16", "i32", "i64", "fp32", "fp64", "dec")), | ||
| SqlStdOperatorTable.DATETIME_PLUS, | ||
| resolver(SqlStdOperatorTable.PLUS, Set.of("date", "time", "timestamp")), | ||
| resolver(SqlStdOperatorTable.DATETIME_PLUS, Set.of("date", "ts", "tstz", "pts", "ptstz")), |
Member
Author
There was a problem hiding this comment.
this somehow still did work with the less specific/wrong SqlOperator. now it uses the right one
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
force-pushed
the
par-datetimeadd
branch
from
b5231c9 to
fe83186
Compare
andrew-coleman
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for precision timestamp addition/subtraction in isthmus.
timefor theDATETIME_PLUSmapping since that is not officially supported in the default Substraitextension:io.substrait:functions_datetimecollection.date,precision_timestampandprecision_timestamp_tz(generated by IBM Bob but I checked them)