Axisymmetric near-axis fixes using L’Hôpital-consistent formulations#2715
Axisymmetric near-axis fixes using L’Hôpital-consistent formulations#2715raghava-davuluri wants to merge 4 commits intosu2code:developfrom
Conversation
Axisymmetric source term: blend dv/dr with v/r near axis
|
Hi @raghava-davuluri, thanks for this fix! Does this case need additional regression tests or is it covered by the existing regression tests for axisymmetric flow? |
|
This is addressing #2438 It helps in most situations, but dips in axisymmetric heating cases can still be present for some meshes. So @raghava-davuluri is doing a pull request to help get more eyes on it. |
|
@raghava-davuluri @bigfooted, reading up on this more, L'Hopital's rule may be more suitable for cell-centered and less so for vertex-centered codes. And that all the residuals should still be zero at the symmetry line. Here is an example of the axisymmetric sources along the surface. I would expect the energy and momentum-x to smoothly go to zero at theta=0 instead of a discontinuity
|
| /*--- Common calculations for both branches ---*/ | ||
| su2double rho = U_i[0]; // density | ||
| su2double u = U_i[1]/U_i[0]; // u-velocity | ||
| su2double v = U_i[2]/U_i[0]; // v-velocity |
There was a problem hiding this comment.
| su2double v = U_i[2]/U_i[0]; // v-velocity | |
| //su2double v = U_i[2]/U_i[0]; // v-velocity |
There was a problem hiding this comment.
@raghava-davuluri can you fix these so the code compiles on github and we see the result of the regression tests?
|
I'd say the source terms should not jump close to r=0, but they are allowed to be nonzero. |

Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.