Fixing Custom Objective Function for Unsteady Adjoint #2587
Fixing Custom Objective Function for Unsteady Adjoint #2587ErcanUmut60 wants to merge 18 commits intosu2code:developfrom
Conversation
pcarruscag
left a comment
There was a problem hiding this comment.
This file is generated via a script, we need to fix or update that script, otherwise the next time someone uses it it will break the custom objective again.
Okay I will look into it but do you mean it is generated during build/install? When I look into source code the file is inside /SU2_PY/SU2/io. |
|
check SU2_PY/updateHistoryMap.py |
…. function and write it into historyMap.py
|
I did some changes in the python file so it can read custom obj. func. from the CFlowOutput.cpp. |
removing json from import.
|
If you run the python script updatehistorymap.py, does it generate the correct, updated, historymap? |
Yes, I tried with Tutorials. There is no problem. |
|
@ErcanUmut60 If you (and the checks) are ready, you can 'squash and merge'. |
I don't see an option for merging the PR. I thought only maintainers were able to do that. |
|
@pcarruscag we merge this PR or not? |
|
Some tests are failing, I was not able to figure out why. |
Defining Custom Objective Function does not work with shape_optimization.py. historyMap.py is updated in order to fix the problem.
pre-commit run --allto format old commits.