fix(consumer): update_topics should only log if topics are recreated
#390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `multi` topics (or regex), when disconnected topic partitions are found, it will recreate their consumers. The logging statement for this was quite noisy in a production environment. Change the code to only log if it finds missing partitions, and also log the topic names so that this functionality can be traced in logs. Fixes: streamnative#389
Contributor
Author
|
@BewareMyPower do you mind having a look at this small change? The cc: @chamons |
chamons
approved these changes
Jan 30, 2026
BewareMyPower
approved these changes
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
multitopics (or regex), when disconnected topic partitions are found, it will recreate their consumers. The logging statement for this was quite noisy in a production environment. Change the code to only log if it finds missing partitions, and also log the topic names so that this functionality can be traced in logs.Fixes: #389