Open
Conversation
added 17 commits
February 15, 2017 10:39
added 2 commits
February 15, 2017 15:22
Lower minimum coverage to avoid failures. Change lib used to set ENV to allow building on older Node versions.
Author
|
Hm, the issue seems to be that much of the ancient stack is not supported on old Node versions. @robertjd @typerandom are these old versions really necessary anymore? The bare-bones build process works there, we know as much, but I cannot seem to find decent replacements for some of the dev tools here, which require Node >= 4. Any change we could migrate Travis to test 4, 6 and 7? We're just pushing a built library anyway. Everything works fine on version 4+. Also, I added just some basic text examples for every type of object in the app. I can either test everything, but that will take a while, or we can go with a policy of adding tests when you touch something (and appropriately moving the minimum coverage percentage up as we go). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for testing the SDK, including React components, through mocha and chai.
Adds coverage reporting via
nyc.Adds some tests for the basic building blocks of the SDK, allowing them to be used as an example for writing tests in the future.
Adds two modes of running tests:
npm run testfor one-time test run + coverage reportingnpm run test:watchfor running tests in watch mode, to be used in developmentFixes #7