Open
Conversation
Where we call the login action when a user can auto-login
Member
|
Thanks @Tweety-FER ! I found one more action call that needed to be updated, please see the commit I added. Are these changes a breaking change? I'm asking because I see that the actions are exported from this module, and they have a new arity. Also: do we need to be updating the documentation in docs/ ? |
added 3 commits
February 1, 2017 11:57
…th/stormpath-sdk-react into feature/form-custom-req-settings
Author
|
Thanks for the fix @robertjd! You're right about the action dispatchers, I forgot that they were public. Added an arity check, so that they can now be used with any combination of Also added a brief note about the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to specify the endpoint on the Form components as a property, as well as on the LoginRoute and LoginLink. Essentially, all components that would call a config-defined endpoint will instead call the given endpoint. If no endpoint is provided, the behaviour remains the same.
Additionally, adds a third optional
headersparameter for all Form components that have support for theonSubmitfunction. This parameter is an object that can be used to manually set some headers before calling the API/back-end intergration. Something like this was asked about in #151.Fixes #120