Fix exception generated when writing to SINT variable and SINT Array …#455
Open
AskicV wants to merge 1 commit intostlehmann:masterfrom
Open
Fix exception generated when writing to SINT variable and SINT Array …#455AskicV wants to merge 1 commit intostlehmann:masterfrom
AskicV wants to merge 1 commit intostlehmann:masterfrom
Conversation
…using write_to_list_by_name function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…using write_to_list_by_name function.
The problem was the line ADST_INT8: PLCTYPE_BYTE, in the file: pyads.constants.py.
Because of this, the following exception was generated when writing negative values to the SINT variable or an Array of SINT: "ubyte format requires 0 <= number <= 255".
The correct way is to use: ADST_INT8: PLCTYPE_SINT, because PLCTYPE_SIN is actually c_byte from ctypes library and not c_ubyte. PLCTYPE_BYTE is c_ubyte and that generated the exception.