Refactoring of pyads_ex in preparation for symbol list feature#269
Merged
stlehmann merged 1 commit intostlehmann:masterfrom Oct 15, 2021
Merged
Refactoring of pyads_ex in preparation for symbol list feature#269stlehmann merged 1 commit intostlehmann:masterfrom
stlehmann merged 1 commit intostlehmann:masterfrom
Conversation
Pull Request Test Coverage Report for Build 1308310190
💛 - Coveralls |
Owner
|
@RobertoRoos great work. Putting the Connection class in its own module was long due. The implementation of the additional support functions also looks good for me. Even the coverage increased. As we have 3 additional functions I think we should add specific unit tests for them even though they are covered by the existing tests. I will create a new issue for this and kindly ask you to take care of it. |
Contributor
Author
|
Thanks. Yes, sounds like a good idea. I am not entirely satisfied with the split of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Connectionclass to it's own filepyads_exintoads...()functions and support methodsContains the general refactoring originally from #268 . This PR should be merged before that other one.
The reason for the new files is the old files were too long. Arguably they still are, but it's a bit better now.
Hm, codefactor.io is not very impressed: https://www.codefactor.io/repository/github/robertoroos/pyads/overview/feature/refactor