Fix: Strip backquote from generated filenames#567
Open
kgott wants to merge 1 commit intostitionai:mainfrom
Open
Fix: Strip backquote from generated filenames#567kgott wants to merge 1 commit intostitionai:mainfrom
kgott wants to merge 1 commit intostitionai:mainfrom
Conversation
Collaborator
|
is this working all the time? like when the ` are not present. |
Contributor
Author
|
It does but it looks like PR #603 supersedes this PR as it was resolved in a different way. |
hashcacher
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #566
Test plan (required)
Previously, the generated filenames were surrounded by backquotes. After running with this change, the generated filenames no longer have backquotes.
Closing issues (optional)
Fixes #566