[Code cleanup] Migrate `pq` code to `pgx` by aditya1702 · Pull Request #525 · stellar/wallet-backend

aditya1702 · 2026-03-02T00:40:45Z

What

Move all existing db code using lib/pq to using pgx
Make DB connection values configurable via cmd flags

Why

lib/pq library is not actively developed and is now under maintenance only. The pgx library is more active in resolving bugs and adding new features. We were already utilizing pgx for COPY inserts since it supported fast binary protocol copy inserts. However, it does not make sense to support 2 different database libraries in the same code, given that we are going to actively add new features to wallet backend.

This cleanup ensures we consistently use the same pgx library everywhere in the code

Known limitations

N/A

Issue that this PR addresses

Closes #529

Tests for Scan, Value, Roundtrip, and String methods following the same pattern as AddressBytea tests.

All test files now use valid hex strings that can be converted to 32-byte BYTEA values instead of simple strings like "tx1", "tx2".

Part of the plan to store XDR data as raw bytes for efficiency.

Similar pattern to HashBytea but uses base64 encoding (standard for XDR) and supports variable-length data.

Changed OperationXDR field from string to XDRBytea for automatic base64/BYTEA conversion.

Cast the base64 XDR string to XDRBytea for proper database storage.

- Change UNNEST cast from text[] to bytea[] - Convert XDRBytea to raw bytes in BatchInsert - Update BatchCopy to pass raw bytes instead of pgtype.Text

Forces GraphQL to use a resolver for operationXdr to convert XDRBytea to base64 string for API consumers.

- Update test_utils.go to use types.XDRBytea - Regenerate GraphQL code with OperationXdr resolver

Returns the XDRBytea as a base64-encoded string for API consumers.

- Use parameterized queries with XDRBytea for SQL inserts - Update assertions to use .String() for comparison - Fix type casting in test data creation

- Use base64-encoded test XDR data in test_utils.go - Add testOpXDR helper functions in test files - Update all assertions to use .String() method

- Update createTestOperation to use proper base64 XDR - Update generateTestOperations to encode test data as base64 - Update operations_test.go with base64 encoding for all test XDR data - Fix assertions to compare against the stored XDRBytea values

This simplifies the XDR storage flow by storing raw bytes directly instead of encoding to base64 and then decoding. The String() method now handles base64 encoding for external representation.

Skip the intermediate base64 encoding step by using MarshalBinary() instead of MarshalBase64(). The raw bytes are now stored directly in XDRBytea.

Remove unnecessary Value() calls since XDRBytea is now []byte. Access raw bytes directly via type conversion.

Decode expected base64 XDR string to raw bytes for comparison since XDRBytea now uses []byte underlying type.

Use raw bytes directly instead of base64-encoded strings when creating test data for XDRBytea fields.

Use raw bytes directly for test XDR data instead of base64-encoding. The String() method will handle base64 encoding for assertions.

Use raw bytes directly instead of pre-encoded base64 string.

Use parameterized queries instead of raw SQL string literals for BYTEA operation_xdr column. Fix .String() assertion to compare base64 values via opXdr1.String().

Use parameterized queries instead of raw SQL string literals for BYTEA operation_xdr column in BatchGetByOperationIDs and BatchGetByStateChangeIDs tests.

Use parameterized queries instead of raw SQL string literals for BYTEA operation_xdr column in BatchGetByOperationIDs test.

Copilot

Pull request overview

This PR migrates the codebase’s PostgreSQL access layer from lib/pq + sqlx patterns to pgx/v5 (pool + tx), updating models, services, and tests accordingly.

Changes:

Replaces db.ConnectionPool/sqlx usage with *pgxpool.Pool, and introduces db.Querier + generic db.QueryOne/QueryMany helpers.
Updates transaction handling to use a single db.RunInTransaction helper (pgx tx), and ports query parameterization to pgx-compatible forms.
Removes DB-bound metrics initialization (drops sqlstats collector wiring) and updates callers/tests to the new metrics constructor.

Reviewed changes

Copilot reviewed 76 out of 77 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
internal/utils/db_errors_test.go	Updates DB error typing tests to use pgx/pgconn error types.
internal/utils/db_errors.go	Switches pq error classification to pgx/pgconn + pgx.ErrNoRows handling.
internal/signing/store/types.go	Updates store interfaces to pgx pool/tx types.
internal/signing/store/mocks.go	Updates mocks to match revised store interfaces.
internal/signing/store/keypairs_model_test.go	Ports keypair fixtures/tests to pgxpool + positional args.
internal/signing/store/keypairs_model.go	Migrates keypair model to pgxpool + pgconn errors + QueryOne.
internal/signing/store/channel_accounts_model_test.go	Ports channel account tests to pgxpool/pgx tx and array args.
internal/signing/store/channel_accounts_model.go	Migrates channel account model to pgxpool + QueryOne/QueryMany + pgx tx methods.
internal/signing/kms_signature_client_test.go	Updates DB pool creation to pass context and pgxpool type.
internal/signing/channel_account_db_signature_client_test.go	Updates mock expectations for revised store method signatures.
internal/signing/channel_account_db_signature_client.go	Switches signature client DB dependency to *pgxpool.Pool and updated store calls.
internal/services/transaction_service_test.go	Updates DB pool construction to new signature (ctx + pgxpool).
internal/services/transaction_service.go	Switches TransactionServiceOptions DB type to *pgxpool.Pool.
internal/services/token_ingestion_test.go	Updates transaction helper name and pgxpool Exec usage in tests.
internal/services/token_ingestion.go	Switches service DB dependency to *pgxpool.Pool and new transaction helper.
internal/services/rpc_service_test.go	Updates DB pool initialization to new signature.
internal/services/kms_import_key_service_test.go	Updates DB pool initialization to new signature.
internal/services/ingest_live.go	Updates ingestion transaction helper call.
internal/services/ingest_backfill.go	Updates recompressor + transaction helper usage for pgxpool.
internal/services/fee_bump_service_test.go	Ports ExecContext to Exec and updates pool initialization.
internal/services/channel_account_service_test.go	Updates mocks and pool initialization to new signatures.
internal/services/channel_account_service.go	Switches service DB dependency to *pgxpool.Pool and pgx tx transaction helper.
internal/serve/serve.go	Removes sqlx-based metrics wiring; uses new metrics constructor; passes ctx to DB open.
internal/serve/httphandler/health_test.go	Updates ingest_store inserts to string values and pgxpool Exec calls.
internal/serve/graphql/resolvers/utils.go	Updates state change cursor field reference after cursor struct change.
internal/serve/graphql/resolvers/transaction.resolvers.go	Updates cursor access to embedded CompositeCursor.
internal/serve/graphql/resolvers/test_utils.go	Ports resolver test DB setup/cleanup to pgxpool and pgx tx.
internal/serve/graphql/resolvers/setup_test.go	Switches test DB pool global to *pgxpool.Pool and new open signature.
internal/serve/graphql/resolvers/queries.resolvers.go	Updates composite cursor formatting after cursor embedding.
internal/serve/graphql/resolvers/account.resolvers.go	Updates composite cursor formatting after cursor embedding.
internal/serve/graphql/dataloaders/statechange_loaders.go	Updates key functions to reflect embedded state change/cursor shapes.
internal/serve/graphql/dataloaders/operation_loaders.go	Updates operation ID access after embedding changes.
internal/metrics/metrics_test.go	Removes sqlite/sqlx setup and updates metrics service constructor usage.
internal/metrics/metrics.go	Removes sqlstats/sqlx dependencies and DB collector registration.
internal/loadtest/runner.go	Removes sqlx metrics dependency and updates tx helper usage.
internal/integrationtests/infrastructure/main_setup.go	Ports DB reads and metrics service init away from sqlx; updates pool opening signature.
internal/integrationtests/infrastructure/backfill_helpers.go	Replaces database/sql direct usage with pgxpool-based helpers.
internal/ingest/timescaledb_test.go	Ports tests to pgxpool + QueryOne helpers.
internal/ingest/timescaledb.go	Updates hypertable configuration helper to accept *pgxpool.Pool and pgx query APIs.
internal/ingest/ingest.go	Switches pool open calls to ctx-based pgxpool versions; removes sqlx metrics wiring.
internal/indexer/types/types.go	Embeds cursor structs directly in “WithCursor” types (CompositeCursor/StateChangeCursor).
internal/db/utils_test.go	Updates advisory lock tests to use pgxpool + pinned connections.
internal/db/utils.go	Updates advisory lock helpers to accept a Querier and use pgx QueryRow/Scan.
internal/db/migrate_test.go	Ports migration tests to pgxpool + QueryOne/QueryMany helpers.
internal/db/migrate.go	Switches migration execution to use stdlib sql.DB wrapper from pgx pool.
internal/db/db_test.go	Updates DB open test to new pgxpool signature.
internal/db/db.go	Replaces ConnectionPool/sqlx abstractions with pgxpool, Querier, tx helper, and query helpers.
internal/data/trustline_balances_test.go	Ports trustline balance tests to pgxpool Exec and new open signature.
internal/data/trustline_balances.go	Migrates trustline balance querying to QueryMany with struct db tags.
internal/data/trustline_assets_test.go	Ports helper queries and tx begins to pgxpool/pgx.
internal/data/trustline_assets.go	Switches model DB dependency to *pgxpool.Pool.
internal/data/transactions_test.go	Ports transactions tests and benchmark metrics wiring to new metrics constructor + pgxpool open.
internal/data/transactions.go	Migrates transaction queries to QueryOne/QueryMany and pgx-compatible cursor aliases.
internal/data/statechanges.go	Migrates state changes queries to QueryMany and pgx-compatible cursor aliases.
internal/data/sac_balances_test.go	Ports SAC balance tests to pgxpool Exec and tx begin.
internal/data/sac_balances.go	Migrates SAC balance querying to QueryMany with proper column aliases/tags.
internal/data/operations.go	Migrates operation queries to QueryOne/QueryMany and pgx-compatible cursor aliases.
internal/data/native_balances_test.go	Ports native balance tests to pgxpool Exec and tx begin.
internal/data/native_balances.go	Migrates native balance querying to QueryOne with struct db tags.
internal/data/models.go	Switches Models.DB to *pgxpool.Pool and updates model constructors.
internal/data/ingest_store_test.go	Ports ingest_store tests to pgxpool and string value inserts; updates tx helper name.
internal/data/ingest_store.go	Migrates ingest_store reads to QueryOne(string) + parsing; ports list queries to QueryMany.
internal/data/contract_tokens_test.go	Ports contract model tests to new tx helper and QueryOne reads.
internal/data/contract_tokens.go	Migrates GetExisting to QueryMany (scalar) and updates DB type.
internal/data/accounts_test.go	Ports accounts tests to pgxpool Exec and new open signature.
internal/data/accounts.go	Migrates account queries to QueryOne/QueryMany and updates DB type.
internal/data/account_contract_tokens.go	Migrates contract list query to QueryMany and updates DB type.
go.mod	Removes direct deps on pq/sqlx/sqlite/sqlstats and reclassifies some as indirect.
cmd/utils/utils.go	Updates signature client options DB type to *pgxpool.Pool.
cmd/serve.go	Removes pq driver import; updates DB pool opening to ctx-based signature.
cmd/ingest.go	Removes pq driver import.
cmd/distribution_account.go	Updates DB pool opening to ctx-based signature.
cmd/channel_account.go	Removes sqlx-based metrics wiring; updates pool close behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/db/db.go

internal/ingest/ingest.go

Copilot

Pull request overview

Copilot reviewed 79 out of 80 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

internal/db/utils.go:28

ReleaseAdvisoryLock scans the boolean result of pg_advisory_unlock into released but then ignores it and always returns nil. This makes it impossible to detect when the lock was not actually held/released. Consider returning an error (or returning the boolean) when released is false so callers can react appropriately.
internal/metrics/metrics.go:377
NewMetricsService/registerMetrics no longer register any DB/pool-level metrics (previously done via sqlstats). This is a functional observability regression: operators will lose visibility into DB connection usage/health via Prometheus. Consider adding an equivalent collector based on pgxpool.Pool.Stat() (or wiring a *sql.DB via stdlib.OpenDBFromPool into a collector) so existing DB metrics remain available after the pgx migration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/db/db.go

aristidesstaffieri · 2026-03-11T21:04:03Z

internal/metrics/metrics.go

+	))
+
+	m.registry.MustRegister(prometheus.NewGaugeFunc(
+		prometheus.GaugeOpts{


should this use a CounterFunc instead? Most other cumulative metrics do.

aristidesstaffieri · 2026-03-11T21:08:12Z

internal/db/db.go

-// checking. This cannot be set via connection string and requires elevated privileges (superuser
-// or replication role). Call this ONCE at backfill startup after creating the connection pool.
-func ConfigureBackfillSession(ctx context.Context, db ConnectionPool) error {
-	_, err := db.ExecContext(ctx, "SET session_replication_role = 'replica'")


it looks like we didn't port this over, do we no longer need it?

aristidesstaffieri · 2026-03-11T21:12:18Z

internal/db/db.go

-	MaxIdleDBConns    = 20              // Keep warm connections ready in the pool
-	MaxDBConnLifetime = 5 * time.Minute // Recycle connections periodically
+	DefaultMaxConnIdleTime time.Duration = 10 * time.Second
+	DefaultMaxConns        int32         = 10


This change looks unrelated to the library migration. Is this informed by our dev instance metrics?

aristidesstaffieri · 2026-03-12T16:25:10Z

Bug: `ReleaseAdvisoryLock` ignores `released=false` — silent lock leak

File: internal/db/utils.go lines 20-29

func ReleaseAdvisoryLock(ctx context.Context, q Querier, lockKey int) error {
	sqlQuery := "SELECT pg_advisory_unlock($1)"
	var released bool
	err := q.QueryRow(ctx, sqlQuery, lockKey).Scan(&released)
	if err != nil {
		return fmt.Errorf("executing pg_advisory_unlock(%v): %w", lockKey, err)
	}
	return nil // BUG: 'released' is scanned but never checked
}

pg_advisory_unlock() returns false when the lock was not held by the current session (e.g., if the lock was acquired on a different pooled connection than the one used for release). The new code correctly scans the return value into released, but then discards it and returns nil unconditionally. The caller believes the lock was released when it wasn't.

The lock remains held until the session terminates, which could block other processes (e.g., ingestion) from acquiring the same advisory lock.

Suggested fix:

if !released {
	return fmt.Errorf("pg_advisory_unlock(%v) returned false: lock was not held by this session", lockKey)
}
return nil

(Note: this file doesn't appear in the GitHub PR diff — likely because the merge base already includes it — but the change is part of the pgx-migration branch.)

aristidesstaffieri · 2026-03-12T16:27:31Z

Bug: `rowScanner` misclassifies `time.Time`, `uuid.UUID`, and similar types as structs

File: internal/db/db.go lines 176-182

func rowScanner[T any]() func(pgx.CollectableRow) (T, error) {
	var t T
	if typ := reflect.TypeOf(t); typ != nil && typ.Kind() == reflect.Struct {
		return pgx.RowToStructByNameLax[T]
	}
	return pgx.RowTo[T]
}

The reflect.Kind() == reflect.Struct check is used to decide whether to scan via named struct fields (RowToStructByNameLax) or as a scalar (RowTo). The problem is that Go types like time.Time, uuid.UUID, and pgtype.* are all structs by reflect.Kind, but they should be scanned as scalars.

If anyone writes QueryOne[time.Time](ctx, pool, "SELECT NOW()"), it will route through RowToStructByNameLax, which tries to match DB column names to db struct tags. time.Time has no db tags, so RowToStructByNameLax (the Lax variant silently ignores mismatches) returns a zero time.Time{} with no error. Same for uuid.UUID and other scalar-like struct types.

Current impact: Low — the codebase currently only uses QueryOne/QueryMany with purpose-built model structs (which have db tags) or primitives like string/uint32. But this is a latent trap: any future QueryOne[time.Time] or QueryOne[uuid.UUID] call will silently return zero values with no error.

Possible fix: Check for known scalar struct types, or check for db tag presence:

func rowScanner[T any]() func(pgx.CollectableRow) (T, error) {
	var t T
	typ := reflect.TypeOf(t)
	if typ != nil && typ.Kind() == reflect.Struct && hasDBTags(typ) {
		return pgx.RowToStructByNameLax[T]
	}
	return pgx.RowTo[T]
}

func hasDBTags(t reflect.Type) bool {
	for i := range t.NumField() {
		if _, ok := t.Field(i).Tag.Lookup("db"); ok {
			return true
		}
	}
	return false
}

(Note: this file doesn't appear in the GitHub PR diff — likely because the merge base already includes it — but the change is part of the pgx-migration branch.)

aditya1702 added 30 commits February 5, 2026 11:05

Add HashBytea unit tests

a041358

Tests for Scan, Value, Roundtrip, and String methods following the same pattern as AddressBytea tests.

Update test files with valid 64-char hex hashes

4c1e5dc

All test files now use valid hex strings that can be converted to 32-byte BYTEA values instead of simple strings like "tx1", "tx2".

fix tests

09348d9

add resolver for hash

d238b0b

Update statechanges.go

d6526ef

fix all tests

6ff993f

fix more tests

5058261

Update ingest_test.go

6477fa9

Change operation_xdr column from TEXT to BYTEA

1829d3e

Part of the plan to store XDR data as raw bytes for efficiency.

Add XDRBytea type for storing XDR data as BYTEA

c844520

Similar pattern to HashBytea but uses base64 encoding (standard for XDR) and supports variable-length data.

Update Operation struct to use XDRBytea type

b5ac8ad

Changed OperationXDR field from string to XDRBytea for automatic base64/BYTEA conversion.

Update ConvertOperation to use XDRBytea type

c23554e

Cast the base64 XDR string to XDRBytea for proper database storage.

Update operations.go for BYTEA operation_xdr storage

23ba111

- Change UNNEST cast from text[] to bytea[] - Convert XDRBytea to raw bytes in BatchInsert - Update BatchCopy to pass raw bytes instead of pgtype.Text

Add forceResolver directive to operationXdr field

a347cc7

Forces GraphQL to use a resolver for operationXdr to convert XDRBytea to base64 string for API consumers.

Run gql-generate and fix test_utils.go type

ddaeeee

- Update test_utils.go to use types.XDRBytea - Regenerate GraphQL code with OperationXdr resolver

Implement OperationXdr GraphQL resolver

aee79f2

Returns the XDRBytea as a base64-encoded string for API consumers.

Update tests to use XDRBytea type

00eeaa3

- Use parameterized queries with XDRBytea for SQL inserts - Update assertions to use .String() for comparison - Fix type casting in test data creation

Update GraphQL resolver tests for XDRBytea type

ec34cef

- Use base64-encoded test XDR data in test_utils.go - Add testOpXDR helper functions in test files - Update all assertions to use .String() method

Change XDRBytea underlying type from string to []byte

525a59d

This simplifies the XDR storage flow by storing raw bytes directly instead of encoding to base64 and then decoding. The String() method now handles base64 encoding for external representation.

Use MarshalBinary directly in ConvertOperation

5e221f7

Skip the intermediate base64 encoding step by using MarshalBinary() instead of MarshalBase64(). The raw bytes are now stored directly in XDRBytea.

Simplify BatchInsert and BatchCopy in operations.go

ce12f8a

Remove unnecessary Value() calls since XDRBytea is now []byte. Access raw bytes directly via type conversion.

Update utils_test.go for XDRBytea []byte type

52bdb28

Decode expected base64 XDR string to raw bytes for comparison since XDRBytea now uses []byte underlying type.

Update operations_test.go for XDRBytea []byte type

5bb41f3

Use raw bytes directly instead of base64-encoded strings when creating test data for XDRBytea fields.

Update test_utils.go for XDRBytea []byte type

a5429a0

Use raw bytes directly for test XDR data instead of base64-encoding. The String() method will handle base64 encoding for assertions.

Update ingest_test.go for XDRBytea []byte type

41dfbf7

Use raw bytes directly instead of pre-encoded base64 string.

Fix operations_test.go for XDRBytea []byte type

bd27099

Use parameterized queries instead of raw SQL string literals for BYTEA operation_xdr column. Fix .String() assertion to compare base64 values via opXdr1.String().

Fix accounts_test.go for XDRBytea []byte type

762593e

Use parameterized queries instead of raw SQL string literals for BYTEA operation_xdr column in BatchGetByOperationIDs and BatchGetByStateChangeIDs tests.

Fix transactions_test.go for XDRBytea []byte type

5f26b91

Use parameterized queries instead of raw SQL string literals for BYTEA operation_xdr column in BatchGetByOperationIDs test.

Update generated.go

25ccec9

aditya1702 added 5 commits March 6, 2026 13:32

Merge branch 'remove-filtering' into query-optimize-2

554c169

Merge branch 'main' into query-optimize-2

b14ee78

Add LEFT JOIN LATERAL

f774713

Merge branch 'query-optimize-2' into pgx-migration

60a14ca

reference cursor_* fields directly since pgx flattens everything

835eb77

Base automatically changed from query-optimize-2 to main March 11, 2026 14:08

Merge branch 'main' into pgx-migration

09d4e29

aditya1702 changed the title ~~Pgx migration~~ Migrate pq code to pgx Mar 11, 2026

remove cursor. reference and directly reference the cursor_id column

7f564bd

aditya1702 marked this pull request as ready for review March 11, 2026 14:38

Copilot AI review requested due to automatic review settings March 11, 2026 14:38

Copilot started reviewing on behalf of aditya1702 March 11, 2026 14:39 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

internal/db/db.go Outdated Show resolved Hide resolved

internal/db/db.go Outdated Show resolved Hide resolved

internal/db/db.go Outdated Show resolved Hide resolved

internal/ingest/ingest.go Outdated Show resolved Hide resolved

aditya1702 changed the title ~~Migrate pq code to pgx~~ [Code cleanup] Migrate pq code to pgx Mar 11, 2026

Pool conn config (#526)

3e81171

aditya1702 requested a review from Copilot March 11, 2026 15:42

Copilot started reviewing on behalf of aditya1702 March 11, 2026 15:42 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

internal/db/db.go Outdated Show resolved Hide resolved

aditya1702 added 6 commits March 11, 2026 13:19

Add db helper for querying into pointer structs

9c5f307

Add tests for the QueryOne, QueryMany methods

56b0da5

remove disable statement cache

4b905e5

Acquire a connection for the advisory lock

b739b58

Expose DB pool metrics

ff7edbe

Update channel_accounts_model.go

8b15423

aditya1702 requested a review from a team March 11, 2026 19:34

aristidesstaffieri reviewed Mar 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Code cleanup] Migrate `pq` code to `pgx`#525

[Code cleanup] Migrate `pq` code to `pgx`#525
aditya1702 wants to merge 816 commits intomainfrom
pgx-migration

aditya1702 commented Mar 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

aristidesstaffieri Mar 11, 2026

Uh oh!

aristidesstaffieri Mar 11, 2026

Uh oh!

aristidesstaffieri Mar 11, 2026

Uh oh!

aristidesstaffieri commented Mar 12, 2026

Uh oh!

aristidesstaffieri commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

aditya1702 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Known limitations

Issue that this PR addresses

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

aristidesstaffieri Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

aristidesstaffieri Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

aristidesstaffieri Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

aristidesstaffieri commented Mar 12, 2026

Bug: ReleaseAdvisoryLock ignores released=false — silent lock leak

Uh oh!

aristidesstaffieri commented Mar 12, 2026

Bug: rowScanner misclassifies time.Time, uuid.UUID, and similar types as structs

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aditya1702 commented Mar 2, 2026 •

edited

Loading

Bug: `ReleaseAdvisoryLock` ignores `released=false` — silent lock leak

Bug: `rowScanner` misclassifies `time.Time`, `uuid.UUID`, and similar types as structs