allow passing binary data structs as attachments#87
allow passing binary data structs as attachments#87azhi wants to merge 1 commit intostavro:masterfrom
Conversation
pedep
left a comment
pedep
left a comment
There was a problem hiding this comment.
Thanks for another one!
This seems to be a much requested feature - Nice to have it completed 🎉
Specs run on my machine 👍
|
I'm curious when this would be merged? |
|
@stavro is there any chance of this being merged soon? Or is there another solution that you'd recommend. |
|
That would be very usefull ; could you pls merge it ? txs |
|
up |
|
merge plz |
|
Is there a reason you're not merging this? Really need this PR |
|
merge plz |
|
I'm also looking forward for this merge! |
|
To have this merged would be of great help! |
|
Up, it would be great to have this merged, for now I had to run my own fork to go around the situation.. thanks @azhi for finding a solution 🙇 |
|
@tiagonbotelho would you mind sharing that fork? @stavro is this repo being maintained any more? There are a lot of very useful PRs that are over a year old just gathering dust. |
|
@jprincipe sure thing I forked it here: https://github.com/duffelhq/arc_ecto 👍 I just fixed what was blocking my work. I have no current plans of maintaining my own fork. But if that changes in the future I'll be sure to post it here 😊 |
|
Thanks @tiagonbotelho, I ended up forking master and manually pulled in the PR from @azhi. I'm going to try and go through some of the existing PRs and see what makes sense to pull in. Unsure if I'll continue to maintain it though. |
arc allows storing `%{filename: filename, binary: data}`,
and now arc_ecto allows these structs to be accepted in
`cast_attachments`
fixes stavro#54
azhi
force-pushed
the
allow-binary-data-attachments
branch
from
9c6c9d5 to
4a4fe6e
Compare
|
Hi @stavro , Do you have any plans to merge this PR? |
14 participants
arc allows storing
%{filename: filename, binary: data},and now arc_ecto allows these structs to be accepted in
cast_attachmentsfixes #54