fix: use setting instead of global_settings for AppSettings#104
Merged
sstadick merged 1 commit intosstadick:masterfrom Feb 4, 2026
Merged
fix: use setting instead of global_settings for AppSettings#104sstadick merged 1 commit intosstadick:masterfrom
setting instead of global_settings for AppSettings#104sstadick merged 1 commit intosstadick:masterfrom
Conversation
The use of `global_settings` causes AppSettings to propagate to all subcommands/substructs, which breaks positional argument parsing. Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
force-pushed
the
fix/subcommand-settings
branch
from
8aa0de1 to
bbdd202
Compare
Owner
|
Oh man. That's embarrassing. Thanks for the fix! I'll get that merged in and released ASAP 👍 |
Owner
|
See v1.4.0 release. Thanks again! |
Contributor
Author
|
@sstadick thanks for the quick turnaround!! 💯 ❤️ |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of
global_settingscauses AppSettings to propagate to all subcommands/substructs, which breaks positional argument parsing.