Added Alt tags to images and added meta description to index.html#58
Open
nel417 wants to merge 3 commits intosquare:masterfrom
nel417:master
Open
Added Alt tags to images and added meta description to index.html#58nel417 wants to merge 3 commits intosquare:masterfrom nel417:master
nel417 wants to merge 3 commits intosquare:masterfrom
nel417:master
Conversation
Added meta description, SEO is scoring a 78 via Lighthouse. Alt tags will help the accessibility and SEO for the square open source portal.
Added alt tags to images, Accessibility is scoring dangerously low at 36 and feel like alt tags would be a good start for accessibility and SEO, if you feel the repo descriptions (that display when the image is hovered over) would be a better fit instead of the logo(repo) name, I would be more than happy to swap them out.
zach-klippenstein
suggested changes
Jun 27, 2020
Contributor
There was a problem hiding this comment.
This is good, thanks! Unfortunately the file you modified, index.html is generated (see the README). To make this actually stick past the next generation, you'll need to edit the moustache template instead, and then run the script to regenerate the HTML.
Author
|
sounds good, I'll hop on the changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accessibility was dangerously low for the site (36 via lighthouse) and thought alt tags would be a good start for the overall accessibility and SEO.
Added meta description for SEO, it was scoring fairly low as well (78 via lighthouse)
If alt tags should be the images description over hover instead of the name of the repo, I would be more than happy to change them.