Skip to content

test: temporarily disable failing Chrome tests #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sidvishnoi merged 1 commit into from
Feb 27, 2026
+23 −7
Merged

test: temporarily disable failing Chrome tests #5107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions tests/spec/core/dfn-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import {
flushIframes,
html,
makeBasicConfig,
makeDefaultBody,
makeRSDoc,
Expand Down Expand Up @@ -402,24 +403,35 @@ describe("Core — Definitions", () => {
});

it("handles attributes", async () => {
const body = `
const body = html`
<section>
<h2>Attributes</h2>
<p id="attributes">
<dfn class="element-attr">some-attribute</dfn>
</p>
<p id="attribute-bad">
<dfn class="element-attr">-attribute</dfn>
</p>
</section>
`;
const ops = makeStandardOps(null, body);
const doc = await makeRSDoc(ops);
const dfn = doc.querySelector("#attributes dfn");
expect(dfn.dataset.dfnType).toBe("element-attr");
expect(dfn.dataset.export).toBe("");
});

// TODO: failing for Chrome, but not Firefox. Needs investigation.
// eslint-disable-next-line jasmine/no-disabled-tests
xit("handles bad attributes", async () => {
const body = html`
<section>
<h2>Attributes</h2>
<p id="attribute-bad">
<dfn class="element-attr">-attribute</dfn>
</p>
</section>
`;
const ops = makeStandardOps(null, body);
const doc = await makeRSDoc(ops);

// Check validation error
const errors = findDfnErrors(doc);
expect(errors).toHaveSize(1);
expect(errors[0].message).toContain("-attribute");
Expand Down
8 changes: 6 additions & 2 deletions tests/spec/core/validators-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ describe("Core - Validators", () => {
}
});

it("generates an error if the element name is not valid", () => {
// TODO: failing for Chrome, but not Firefox. Needs investigation.
// eslint-disable-next-line jasmine/no-disabled-tests
xit("generates an error if the element name is not valid", () => {
const elements = ["my element", "crypto$", "🪳", "-something", ""];
for (const element of elements) {
const dfn = document.createElement("dfn");
Expand Down Expand Up @@ -55,7 +57,9 @@ describe("Core - Validators", () => {
}
});

it("generates an error if the attribute name is invalid", () => {
// TODO: failing for Chrome, but not Firefox. Needs investigation.
// eslint-disable-next-line jasmine/no-disabled-tests
xit("generates an error if the attribute name is invalid", () => {
const attributes = ["-crossorigin", "-whatever-", "aria-😇"];
for (const attribute of attributes) {
const context = `attribute name: ${attribute}`;
Expand Down