Skip to content

Don't add cursor: pointer to vars when variable highlighting is inactive #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
twiss wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't add cursor: pointer to vars when variable highlighting is inactive #4870

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
547a2c1
Don't add cursor:pointer to vars when variable highlighting is inactive
twiss Jan 8, 2025
27f41d6
Merge branch 'main' into fix-var-cursor
marcoscaceres Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/styles/datatype.css.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ const css = String.raw;
// Prettier ignore only to keep code indented from level 0.
// prettier-ignore
export default css`
var {
var[data-type] {
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS selector change from var to var[data-type] may create inconsistency if the position: relative property is needed for all var elements, not just those with data-type attributes. Consider whether this positioning change could affect the layout of var elements without data-type attributes.

Suggested change
var[data-type] {
var {

Copilot uses AI. Check for mistakes.
Copy link
Author

@twiss twiss Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed, the position: relative is only to help position the position: absolute ::before and ::after pseudoelements below.

position: relative;
cursor: pointer;
}

var[data-type]::before,
Expand Down