Now will distinguish between status codes the expected inferred type#2100
Now will distinguish between status codes the expected inferred type#2100Boxap wants to merge 4 commits intospec-first:mainfrom
Conversation
|
Did you run |
|
@chrisinmtown nope, originally I just copied the PR from carloscbl, because in that PR the blocker was that test outputs expired. Now I checked the tests and fixed the problems |
|
Please add a test case for this new code. Your PR changes a behavior you didn't like and which no tox test found. Anyhow, the existing tox cases all pass for me. The code coverage improves by a tiny amount :) Is this behavior documented at all? It seems to me maybe this could be explained in https://github.com/spec-first/connexion/blob/main/docs/response.rst I didn't find anything about custom responses or inferred content-type values there yet. |
|
@chrisinmtown Done |
|
Wow that was a quick response, thanks for adding doc and tests. One more thing, you probably want to squash your commits down to just one with a nice message that explains all the work you did. Anyhow I pulled the latest from your repo and the tox tests pass for python 3.9..3.12 so I approved this PR, for what little that means lol. @Ruwann @RobbeSneyders would you please approve a GitHub workflow run on this PR? |
| responses: | ||
| '200': | ||
| description: Echo the validated request. | ||
| '/status-specific-content': |
There was a problem hiding this comment.
Do you want to leave the single quotes off this path, to match the existing style?
Fixes #1956 and #1850 .
(this is a duplicate of PR #1957 by carloscbl. Test failed in original PR)
Changes proposed in this pull request: