login, signup and verification page done#1
Open
ShreyaLaheri wants to merge 5 commits intospaceuptech:masterfrom
Open
login, signup and verification page done#1ShreyaLaheri wants to merge 5 commits intospaceuptech:masterfrom
ShreyaLaheri wants to merge 5 commits intospaceuptech:masterfrom
Conversation
|
|
HeyItsJs
suggested changes
Jul 14, 2020
package.json
Outdated
| "next-react-svg": "^1.1.1", | ||
| "react": "16.13.1", | ||
| "react-dom": "16.13.1", | ||
| "spectre.css": "^0.5.8", |
Contributor
There was a problem hiding this comment.
Why have you installed spectre.css via npm? Uninstall it.
pages/login/login-page.js
Outdated
| <label class="form-label">Email</label> | ||
| <input class="form-input" type="text" placeholder="Type your email address" /> | ||
| </div> | ||
| <div class="form-group"> |
Contributor
There was a problem hiding this comment.
Are you sure we can use class in React? We use className, right?
| @@ -0,0 +1,116 @@ | |||
| .loginBg{ | |||
Contributor
There was a problem hiding this comment.
Will the styling of all pages be inside this file?
Author
There was a problem hiding this comment.
Yes. I've left all the global styles in the global.css file, rest all in this file. However Ketaki hasn't done the same
Contributor
|
Few more changes after seeing the ui @ShreyaLaheri:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.