Conversation
Member
|
I'll take a look at this and try to stage it up on dev to see if we run into any problems with it. |
balmas
added a commit
to sosol/sosol
that referenced
this pull request
Nov 2, 2015
local build of gitwrapper pending acceptance of sosol/gitwrapper#2
Author
|
FYI, I decided to deploy this live on Perseids today since I was worried about other submissions running into problems because of it. Living dangerously. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know @hcayless is away at TEI right now, but didn't want this to get lost in the email shuffle. Given my limited clojure skills, I'm not sure if this introduces any new problems and I'm doubtful it's a full fix for this issue, but it does seem to resolve the error caused by the blob commit being passed in the recursive call to accumulate-diffs.