Conversation
e08c2f4 to
615428b
Compare
| xcrun simctl list devices vision | ||
| system_profiler SPDeveloperToolsDataType | ||
| xcodebuild -showsdks |
There was a problem hiding this comment.
After looking into this a bit, the current default xcode used on the macOS-14 runner is 15.0.1. The visionOS simulator requires xcode 15.2+ and I don't feel like adding in the logic to switch between xcode versions in this CI.
There was a problem hiding this comment.
Well, this still applies. I can either remove visionOS from the CI matrix or we can wait until the macos runner updates the default xcode. I'm not sure what the xcode versioning policy is (if there is one) on github runners.
There was a problem hiding this comment.
How about we do all the steps, including creating the simulator and deleting it, but making the steps that fail (presumably just lines 106 or 107) conditional:
if [ -z "${GITHUB_ACTIONS}" ]; then
# These steps fail in GitHub Actions due to https://...
fi
briansmith
left a comment
There was a problem hiding this comment.
This looks awesome. I didn't test it because I don't have a mac available to me right now. Some comments....
| sim: [ tvOS, watchOS ] | ||
| include: | ||
| - os: macos-14 | ||
| sim: visionOS |
There was a problem hiding this comment.
If you add here:
xcode_version: 15.2
then before you run the shell script you can add a step:
- if: ${{ matrix.xcode_version != '' }}
run: sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode_version }}.app
This is what I've done in my CI.
| xcrun simctl list devices vision | ||
| system_profiler SPDeveloperToolsDataType | ||
| xcodebuild -showsdks |
There was a problem hiding this comment.
How about we do all the steps, including creating the simulator and deleting it, but making the steps that fail (presumably just lines 106 or 107) conditional:
if [ -z "${GITHUB_ACTIONS}" ]; then
# These steps fail in GitHub Actions due to https://...
fi
Apple Vision Pro support was added as a tier 3 target to rust in rust-lang/rust#121419 with
target_osofvisionos.Depends on:
-Zbuild-stdflag foraarch64-apple-visionosor the simulator target.