Disable two tests which require filesystem under wasm32-wasip2#607
Disable two tests which require filesystem under wasm32-wasip2#607ltratt merged 1 commit intosoftdevteam:masterfrom
Conversation
|
I think we should merge this one as-is. I admit that I'm not sure I understand the workspace_runner link? |
|
To explain the workspace_runner link: https://github.com/softdevteam/grmtools/blob/master/.buildbot.sh#L46C1-L46C31 The "workspace_runner" is a binary/test runner for wasmtime, But there was a bug in it where it could sometimes fail to reflect the exit status of the wasmtime process. Edit: I feel I should reiterate that I'm happy to contribute the repo/crate for workspace_runner it to your organization (and continue maintaining it) if that is something you would prefer. |
|
Aha, I'm with you! It's up to you. FWIW I'm 100% happy with it being on your user account and, indeed, I think arguably you deserve the recognition of it being there. |
|
I published a new version of the Edit: It did successfully install the latest version. |
I noticed an oddity in the ci build logs, where a testsuite failure wasn't causing a ci failure.
I've filed this PR to the
workspace_runnerto fix that, and will give some time for comment period before merging)ratmice/workspace_runner#3
This PR disables the tests that were failing.
One of these tests requires filesystem access to
../../lrpar/exampleswhich isn't going to work with the sandboxWhere the workspace runner allows access to everything between the source directory, and the
$OUT_DIR.But doesn't try to enumerate every path within the workspace.
There is a pre-existing comment that this test should be disabled under wasm32, but it seems like it didn't get disabled.
The other one appears like it should work, as in it seems like it should only require access to the
$OUT_DIRdirectory.So it isn't clear to me exactly why it is failing.