Conversation
|
How about make visual studio use cmake instead? Keeping VS support while making cmake (righfully) the build system |
|
Would this allow the project to be built using MINGW? (Unless the project relies on something that only VS has) |
It does, you just open the project folder with visual studio, I've updated the contributing guide to reflect this. |
Should do although untested |
|
I assume this still allows MSBuild to be used? |
I believe it will run the cmake scripts, either way it works fine on my windows box through VS so hopefully should on everyone elses |
|
Looks like my source groups are wrong and include more than needed, likely need to re-generate these based on the old |
|
This is ready for testing, it should be almost identical to the old VS/MSBuild stuff just using CMake. |
|
14h of work and I think its done |
Description
Also restructures files to match the old structure in the visual studio filtersMake source_groups work to keep the project structureThis should also pave the way for builds on other platforms like linux. Note: We have to force MSVC as otherwise the project won't compile due to
reference to 'byte' is ambiguousBuild times will likely be a bit faster due to better handling of
BuildVer.hAlso the Nightly workflow has been re-worked to support multiple platforms later
Toolchains for each of the platforms will need setting up once we are ready to build for those, for now they are empty.
Changes
Previous Behavior
N/A
Root Cause
N/A
New Behavior
N/A
Fix Implementation
N/A
AI Use Disclosure
AI was used to generate the sources groups file from the filters as I really didnt wanna do that by hand.
Related Issues
More info
Theres a bunch of files not used in the repo by the looks of it, atleast they were excluded by every platform from what I could see
Minecraft.Client.Excluded.cmake.txt
Minecraft.World.Excluded.cmake.txt