Fix mouse getting grabbed outside window of the game#629
Closed
KKNecmi wants to merge 9 commits intosmartcmd:mainfrom
Closed
Fix mouse getting grabbed outside window of the game#629KKNecmi wants to merge 9 commits intosmartcmd:mainfrom
KKNecmi wants to merge 9 commits intosmartcmd:mainfrom
Conversation
Contributor
Author
|
with less file edited this already been done on #612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If User uses Windows64 when a ui opens like a furnace does grab(limit your mouse area) your mouse it checks if game in front of the screen if not disable grabbing
https://github.com/user-attachments/assets/70971d59-bcd6-42be-aa04-cfd0227e8112
Changes
Edited KeyboardMouseInput.cpp & KeyboardMouseInput.h
Previous Behavior
Alt tabbing causes mouse stuck at center of the screen
Root Cause
if a ui is open it doesnt check if game is on the screen so it limits everytime effects outside of the game
New Behavior
if a ui is open it checks if the app window in front of the screen if not dont grab mouse
Fix Implementation
added a bool to check if app window in front and use this on tick with ifdef _Windows64 check window if its outside game dont grab if its not grab it
AI Use Disclosure
i used Ai to found the class grabs the mouse so i dont need to look every part of the code
Related Issues