Add Virtual Keyboard to more text inputs#586
Conversation
|
This is pretty good ngl |
|
Please attach a screenshot and gameplay footage. |
Already attached it's at the Preview section. The file was too large to directly upload to GitHub |
|
Don't forget to open an issue in 4JLibs |
|
By the way, we don't need that virtual keyboard if no controller is connected(PC with a keyboard). Does the code check for this? I can't find it. |
You are able to still use the keyboard Arrow Keys and Enter keys for example, but I could make it use the old system if no controller is connected |
|
My point is that there should be no virtual keyboard when an actual keyboard is there and there is no controller. Please implement this behavior. |
|
I think instead of checking if a controller is connected, instead you check what input device entered the text Field. |
So should it use the old system when no controller is connected? |
TL;DR, it should only appear if a controller is connected, but a keyboard is not. |
It now uses the last inputted input |
|
This should probably be done in 4J Input |
|
I don't have perms to merge but is this ready to push? |
|
Issue was already resolved in #539 |
So I should close this one and convert yours to draft? |
Yeah mb i hadn't seen that a pr is already open for it |
|
This addresses things not addressed in #539 like seed and other text prompts, this still has relevance. |
Description
The current system uses windows DialogBox which looks extremely bad and is unusable on Controller. This introduces a virtual keyboard like on consoles
Changes
Previous Behavior
Changing Texts opens a DialogBox
Root Cause
Unusable on controller, looks bad
New Behavior
Opens the new Virtual Keyboard.
Fix Implementation
There had been issues implementing the callback the issue with the current RequestKeyboard method is that it can't take specific values and I cant change its behavior due to it being built into 4j libs.
AI Use Disclosure
AI was only used to come up with an idea on how to do the fallbacks as the issue is with the current #RequestKeyboard system its extremely limited.
Preview:
https://streamable.com/shkdzl