Skip to content

fix: call app.GetSaveThumbnail on _WINDOWS64 for world thumbnails#390

Draft
Patoke wants to merge 1 commit intosmartcmd:mainfrom
Patoke:main
Draft

fix: call app.GetSaveThumbnail on _WINDOWS64 for world thumbnails#390
Patoke wants to merge 1 commit intosmartcmd:mainfrom
Patoke:main

Conversation

@Patoke
Copy link

@Patoke Patoke commented Mar 4, 2026

Description

Allows for saves to show thumbnails when using the 4JLibs project

Implementation

The call for app.GetSaveThumbnail(&pbThumbnailData,&dwThumbnailDataSize); in ConsoleSaveFileOriginal::Flush wasn't triggered as it would only be called on _XBOX and _DURANGO, we added an OR check for _WINDOWS64 too in here

@codeHusky
Copy link
Collaborator

@Patoke Does this supercede anything in #201? I'm about to merge it

@Patoke
Copy link
Author

Patoke commented Mar 4, 2026

@codeHusky Most if not the whole implementation in #201 would be redundant with the 4JLibs project, it should be reverted and re-implemented within 4JLibs

@void2012 void2012 marked this pull request as draft March 4, 2026 10:18
@codeHusky
Copy link
Collaborator

This PR is dependent on us switching to the community version of 4JLibs and should not be merged until that's ready

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the save flush logic so world thumbnails are generated and written on Windows 64-bit builds (needed for 4JLibs-based saves), matching behavior already present on Xbox/Durango.

Changes:

  • Extends the platform preprocessor guard in ConsoleSaveFileOriginal::Flush() to call app.GetSaveThumbnail() on _WINDOWS64 as well as _XBOX/_DURANGO.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants