fix: call app.GetSaveThumbnail on _WINDOWS64 for world thumbnails#390
Draft
Patoke wants to merge 1 commit intosmartcmd:mainfrom
Draft
fix: call app.GetSaveThumbnail on _WINDOWS64 for world thumbnails#390Patoke wants to merge 1 commit intosmartcmd:mainfrom
Patoke wants to merge 1 commit intosmartcmd:mainfrom
Conversation
Collaborator
Author
|
@codeHusky Most if not the whole implementation in #201 would be redundant with the 4JLibs project, it should be reverted and re-implemented within 4JLibs |
Collaborator
|
This PR is dependent on us switching to the community version of 4JLibs and should not be merged until that's ready |
There was a problem hiding this comment.
Pull request overview
Updates the save flush logic so world thumbnails are generated and written on Windows 64-bit builds (needed for 4JLibs-based saves), matching behavior already present on Xbox/Durango.
Changes:
- Extends the platform preprocessor guard in
ConsoleSaveFileOriginal::Flush()to callapp.GetSaveThumbnail()on_WINDOWS64as well as_XBOX/_DURANGO.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows for saves to show thumbnails when using the 4JLibs project
Implementation
The call for
app.GetSaveThumbnail(&pbThumbnailData,&dwThumbnailDataSize);inConsoleSaveFileOriginal::Flushwasn't triggered as it would only be called on _XBOX and _DURANGO, we added an OR check for _WINDOWS64 too in here