Add Debug Nightly Build Workflow and update the README#1270
Add Debug Nightly Build Workflow and update the README#1270xgui4 wants to merge 7 commits intosmartcmd:mainfrom
Conversation
Added a link for the new Nightly Debug build and updated the macOS/Linux support note for clarity.
|
I also don't really see much reason for this to be merged, if you want a debug build, compile it yourself (especially once CMake building is merged, if not already) Also, considering what @codeHusky said under the referenced issue, I don't think it'd be a wise thing to make something that's half-functional and has cheats that can affect multiplayer more public. Personally, I could see this merged if you modify the debug options so that they're labelled if they don't work and also make them only work on singleplayer, and possibly changing the binds too (maybe make them multi-button combinations?) In its current state, I think there's a good reason why debug builds aren't readily available. |
the problem is that the cmake file do not work on GNU/Linux. |
Pretty sure there's a PR that solves that, even then, you can just ask someone to build it for you, use a VM or dualboot to build it on your machine, or just use Actions on your own fork like I hinted at the bottom of my previous reply (which you seemingly didn't read the rest of). |
I somehow didn't read the why given for the PR, and if this is genuinely why you want debug mode, I think it alone already gives a good reason to not merge this. If I was a maintainer for this project, I would've closed this already. |
why ? in creative mode it is great and for those who want to create map too. |
Have you tried this PR? #465 |
this is not uptodate and keep changing so not stable yet |
You don't need the debug menu to access Creative, and looking at the menu itself, I can't really see anything that would be much of actual use. Regardless, this still isn't the proper use for it (actual debugging), and I'd suggest you simply wait until proper commands are added (especially when more gets added to the dedicated server and #1261 gets merged). |
So, why don't you help get it up-to-date, instead of complaining in this? The latest commit in that PR is from only 2-3 days ago, it seems feasible to update it to match upstream. |
i disgree, we should be have that feature as temporaly workaround , and else maybe like disabled multiplayer when on debug mode ??? cause waiting is a great solution, and what about when i play solo ??? i do not have acces to the console command ..... |
because i do not know how lol espcially since it change way too often , idk how to update a pr of someone else .. do a pr of that pr ??? |
I don't see why we need to have the things from it now. |
Basically yeah, well, do a PR of their fork. |
README.md
Outdated
|
|
||
| ## Download | ||
| Windows users can download our [Nightly Build](https://github.com/smartcmd/MinecraftConsoles/releases/tag/nightly)! Simply download the `.zip` file and extract it to a folder where you'd like to keep the game. You can set your username in `username.txt` (you'll have to make this file) | ||
| Windows users can download our [Nightly Build](https://github.com/smartcmd/MinecraftConsoles/releases/tag/nightly) or our new [Nightly Debug](https://github.com/smartcmd/MinecraftConsoles/releases/tag/debug-nightly) for the debug option enabled! Simply download the `.zip` file and extract it to a folder where you'd like to keep the game. You can set your username in `username.txt` (you'll have to make this file) or |
There was a problem hiding this comment.
I do not like the way this is worded, the debug menu is NOTHING new, it was basically on for all builds until somewhat recently now that saves and other core features have gotten more stable.
Also, the tag description in the workflow should be modified to have an actual description for what it is, similar to the one for the Dedicated Server.
|
Forgot to actually send this review earlier, lol |
|
Read the existing 100 github issues about this before you. We're not doing this |
Description
Add a debug nighty build workflow that a lot of Linux player like me and silverhadch want as you removed the debug menu in release mode and forced to compile the game which is not very fun or fair for Linux user, so i create this pr to add that debug version pre-compiled for those who want that like me.
Changes
Previous Behavior
People had to compile the game in debug mode to re-enable the debug feature as they were no debug release pre-compiled.
Root Cause
This project lack a feature present in the leak that make it better and fun as LCE lack the cheat command present on Java and Bedrock so the debug menu is a must imo.
New Behavior
Fix Implementation
Now each commit will have a Nighly build release in debug mode with the debug menu enabled.
AI Use Disclosure
Just the commit name were proposed by GitHub automatically by copilot but the code change was made by me.
Related Issues