Skip to content

feat: add placeholder to app name prompt in create command#370

Merged
mwbrooks merged 3 commits intomainfrom
mwbrooks-create-name-prompt-placeholder
Mar 10, 2026
Merged

feat: add placeholder to app name prompt in create command#370
mwbrooks merged 3 commits intomainfrom
mwbrooks-create-name-prompt-placeholder

Conversation

@mwbrooks
Copy link
Member

@mwbrooks mwbrooks commented Mar 7, 2026 •
edited
Loading

Changelog

Updated the create command's app name prompt to show the randomly generated app name as placeholder text. You can press Enter to accept the default name or type a new name.

Summary

This pull request updated the create command's app name prompt to show the randomly generated app name as placeholder text.

  • Introduces a placeholder text for Survey and Charm
  • Removes printing a separate hint line
  • Users can press enter to accept the placeholder (randomly generated name) or type a new name

Screenshots

Survey:

image

Charm:

image

Preview

Survey:

2026-03-06-create-placeholder-survey.mov

Charm:

2026-03-06-create-placeholder-charm.mov

Requirements

@mwbrooks
feat: add placeholder to app name prompt in create command
6519ac6 
Show the randomly generated app name as placeholder text in the input
field instead of printing a separate hint line. This provides a cleaner
UX where users see the default name inline and can press Enter to accept.
@mwbrooks mwbrooks added this to the Next Release milestone Mar 7, 2026
@mwbrooks mwbrooks self-assigned this Mar 7, 2026
@mwbrooks mwbrooks added enhancement M-T: A feature request for new functionality changelog Use on updates to be included in the release notes semver:minor Use on pull requests to describe the release version increment labels Mar 7, 2026
@mwbrooks mwbrooks marked this pull request as ready for review March 7, 2026 01:05
@mwbrooks mwbrooks requested a review from a team as a code owner March 7, 2026 01:05
@codecov
Copy link

codecov bot commented Mar 7, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.24%. Comparing base (4973cd6) to head (5a3b575).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/iostreams/survey.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   65.27%   65.24%   -0.03%     
==========================================
  Files         216      216              
  Lines       17991    17994       +3     
==========================================
- Hits        11743    11741       -2     
- Misses       5159     5162       +3     
- Partials     1089     1091       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mwbrooks
mwbrooks commented Mar 7, 2026
View reviewed changes
Copy link
Member Author

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for the kinda reviewers!

internal/iostreams/survey.go
Comment on lines 181 to +183
type InputPromptConfig struct {
Required bool // Whether the input must be non-empty
Required bool // Whether the input must be non-empty
Placeholder string // Placeholder text shown when input is empty
Copy link
Member Author

@mwbrooks mwbrooks Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Using Survey's built-in placeholder option

internal/iostreams/charm.go
func buildInputForm(message string, cfg InputPromptConfig, input *string) *huh.Form {
field := huh.NewInput().
Title(message).
Placeholder(cfg.Placeholder).
Copy link
Member Author

@mwbrooks mwbrooks Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Using Charm's built-in placeholder option. I chose the Placeholder name to align with huh rather than survey

Copy link
Member

@zimeg zimeg Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍀 praise: Nice call! This ought bring good patterns onward!

zimeg
zimeg approved these changes Mar 9, 2026
View reviewed changes
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks Awesome find to the care of outputs in a create experience! LGTM! 🎁 ✨

internal/iostreams/charm.go
func buildInputForm(message string, cfg InputPromptConfig, input *string) *huh.Form {
field := huh.NewInput().
Title(message).
Placeholder(cfg.Placeholder).
Copy link
Member

@zimeg zimeg Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍀 praise: Nice call! This ought bring good patterns onward!

@mwbrooks
Copy link
Member Author

mwbrooks commented Mar 10, 2026

Woo woo, appreciate the rolling reviews @zimeg! 🤾🏻 This is a nice little UX improvement to land. I'm excited for it! :shipit:

@mwbrooks mwbrooks merged commit 2ae86a3 into main Mar 10, 2026
7 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-create-name-prompt-placeholder branch March 10, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimeg zimeg zimeg approved these changes

Assignees

@mwbrooks mwbrooks

Labels

changelog Use on updates to be included in the release notes enhancement M-T: A feature request for new functionality semver:minor Use on pull requests to describe the release version increment

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

2 participants

@mwbrooks @zimeg