Open
Conversation
Collaborator
There was a problem hiding this comment.
Hm, I wonder if we should normalize metrics as their own model, since we might want to query over them (e.g. 'get the average response time per task grouped by task type').
What do you think? Is there a reason you chose to keep it as denormalized JSON here?
Collaborator
|
I made some comments: let's resolve them before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added JQuery code to track worker behavior.
Modified Django model to store metrics(Currently store in the 'metrics' field of the CrowdWorkerResponse model).
I have tested this by using the DHC to test the crowd server alone, using psql to see if metrics have been stored into the database and running the CrowdDemo.