-
-
Notifications
You must be signed in to change notification settings - Fork 5
SF-3677 Use the verse the user has selected in the New Question dialog #3652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3652 +/- ##
==========================================
+ Coverage 81.90% 81.91% +0.01%
==========================================
Files 618 618
Lines 38551 38560 +9
Branches 6304 6310 +6
==========================================
+ Hits 31574 31587 +13
- Misses 6004 6012 +8
+ Partials 973 961 -12 ☔ View full report in Codecov by Sentry. |
2c2e9a3 to
c179b60
Compare
RaymondLuong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement!
@RaymondLuong3 reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman).
|
Please also update the commit message to be more meaningful and descriptive of the user facing change. |
c179b60 to
0aa64f5
Compare
pmachapman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the commit message to be more meaningful and descriptive of the user facing change.
Is this clearer?
@pmachapman made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pmachapman).
2c865a8 to
8dc83dd
Compare
be02e4a to
3861581
Compare
3861581 to
2070e61
Compare
This PR allows selection of a verse in the Community Checking Questions and Answers area, and have the selected verse become the verse reference for that question when you click "Add Question".
As a part of this, clicking on a verse if you have the permission to create questions will highlight that verse in the text in Community Checking.
This change is