Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jan 27, 2026

This PR allows selection of a verse in the Community Checking Questions and Answers area, and have the selected verse become the verse reference for that question when you click "Add Question".

As a part of this, clicking on a verse if you have the permission to create questions will highlight that verse in the text in Community Checking.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.91%. Comparing base (e285369) to head (2070e61).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pp/src/app/checking/checking/checking.component.ts 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3652      +/-   ##
==========================================
+ Coverage   81.90%   81.91%   +0.01%     
==========================================
  Files         618      618              
  Lines       38551    38560       +9     
  Branches     6304     6310       +6     
==========================================
+ Hits        31574    31587      +13     
- Misses       6004     6012       +8     
+ Partials      973      961      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement!

@RaymondLuong3 reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jan 30, 2026
@RaymondLuong3 RaymondLuong3 self-assigned this Jan 30, 2026
@RaymondLuong3
Copy link
Collaborator

Please also update the commit message to be more meaningful and descriptive of the user facing change.

@pmachapman pmachapman changed the title SF-3677 User selection is disregarded by the New Question dialog SF-3677 Use the verse the user has selected in the New Question dialog Feb 1, 2026
Copy link
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the commit message to be more meaningful and descriptive of the user facing change.

Is this clearer?

@pmachapman made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pmachapman).

@pmachapman pmachapman force-pushed the fix/SF-3677 branch 2 times, most recently from 2c865a8 to 8dc83dd Compare February 1, 2026 20:36
@pmachapman pmachapman force-pushed the fix/SF-3677 branch 2 times, most recently from be02e4a to 3861581 Compare February 9, 2026 21:50
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Feb 11, 2026
@Nateowami Nateowami enabled auto-merge (squash) February 11, 2026 14:52
@Nateowami Nateowami merged commit 3400d6a into master Feb 11, 2026
20 of 21 checks passed
@Nateowami Nateowami deleted the fix/SF-3677 branch February 11, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants