Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 72.81% 72.81%
=======================================
Files 424 424
Lines 36213 36209 -4
Branches 4996 4996
=======================================
- Hits 26368 26367 -1
+ Misses 8744 8740 -4
- Partials 1101 1102 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
approved these changes
Feb 12, 2026
Contributor
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
Good job!
@ddaspit reviewed 176 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of sillsdev/serval#824
I also updated the dependencies. Most of the code changes come from either the CSharpier update, or the update to NUnit, which removed the old Assert syntax (technically moved it to
ClassicAssert, but I figured I might as well update all of the tests to use the new syntax - I did this via Regex).Each of the changes are split into a different commit, so if you don't want any of them to go ahead, I can drop these from the PR easily.
This change is