[Merged by Bors] - 1.57.0 lints#2850
Closed
realbigsean wants to merge 6 commits intosigp:unstablefrom
Closed
Conversation
pawanjay176
reviewed
Dec 2, 2021
Contributor
|
for the record, this is the source of the new dead_code warnings: rust-lang/rust#85200 |
realbigsean
added
work-in-progress
realbigsean
added
ready-for-review
bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2021
## Issue Addressed New rust lints ## Proposed Changes - Boxing some enum variants - removing some unused fields (is the validator lockfile unused? seemed so to me) ## Additional Info - some error fields were marked as dead code but are logged out in areas - left some dead fields in our ef test code because I assume they are useful for debugging? Co-authored-by: realbigsean <seananderson33@gmail.com>
michaelsproul
added
ready-for-merge
|
Timed out. |
Member
|
Don't know if it's a Windows regression in Rust 1.57.0 or just flaky CI but the Windows build exceeded the 2h timeout: https://github.com/sigp/lighthouse/actions/runs/1533104768 I'll retry it, but if it fails again we'll have bump the timeout in bors retry |
bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2021
## Issue Addressed New rust lints ## Proposed Changes - Boxing some enum variants - removing some unused fields (is the validator lockfile unused? seemed so to me) ## Additional Info - some error fields were marked as dead code but are logged out in areas - left some dead fields in our ef test code because I assume they are useful for debugging? Co-authored-by: realbigsean <seananderson33@gmail.com>
|
Build failed: |
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2021
## Issue Addressed New rust lints ## Proposed Changes - Boxing some enum variants - removing some unused fields (is the validator lockfile unused? seemed so to me) ## Additional Info - some error fields were marked as dead code but are logged out in areas - left some dead fields in our ef test code because I assume they are useful for debugging? Co-authored-by: realbigsean <seananderson33@gmail.com>
|
Pull request successfully merged into unstable. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
New rust lints
Proposed Changes
Additional Info