-
Notifications
You must be signed in to change notification settings - Fork 20
doc: Add Approvers to Maintainers List #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
doc: Add Approvers to Maintainers List #293
Conversation
|
/approve Self-approving /assign @qu1queee For review |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MAINTAINERS.md
Outdated
| | Ayush Satyam | Red Hat | [@ayushsatyam146](https://github.com/ayushsatyam146) | | ||
| | Hasan Awad | Red Hat | [@hasanawad94](https://github.com/hasanawad94) | | ||
| | Matthias Diester | IBM | [@HeavyWombat](https://github.com/HeavyWombat) | | ||
| | Otávio Fernandes | Red Hat | [@otaviof](https//github.com/otaviof) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Otavio still want to be on that list ? I remember him asking to be removed from some PRs in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - I should remove him as he requested to marked as "emertius" back in 2024. It's there in the CLI repo, though at this point it makes sense to be set for all repos.
- Update the maintainers list to also recognize approvers. - Add link to governance and contributor ladder. - Promote @hasanawad94 to maintainer! Assisted-by: Cursor Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
29a9420 to
e081335
Compare
| | Adam Kaplan | Red Hat | [adambkaplan](https://github.com/adambkaplan) | Administrator, Maintainer | | ||
| | Enrique Encalada | IBM | [qu1queee](https://github.com/qu1queee) | Administrator, Maintainer | | ||
|
|
||
| | Hasan Awad | Red Hat | [@hasanawad94](https://github.com/hasanawad94) | Administrator, Maintainer | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SaschaSchwarze0 @qu1queee updated to promote @hasanawad94 to maintainer!
Changes
/kind documentation
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes