Dru

[DruCallaghan]

Implemented a VQVAE on the OASIS dataset

[SiyuLiu0329]

This is an initial inspection, no action is required at this point

Difficulty: Hard

Readme Overall: 
Good

• Project Overview: Good
• Model: Good
• Data + Preprocessing: Good
• Usage: Good
• Training / Loss Curve(s): Good
• Result Demonstration: Good
• References: Good

Functionality:

• Reconstruction: Good
• Generation: Good

Code:

• Consistent with Results: Yes
  - File Structure: Good, but the files are in the wrong folder
• Commenting: Good
• Commit frequency: Good
• Commit messages: Good

Other Comments:

• Please set pull request target to the recognition branch of Shakes' repo, not main.
• Did you fork Shakes' recognition branch, seems like you have been working from his main branch
• Please move all your files into your designated folder: [repo_root]/recognition/[your_folder]/[your_files_here]

[shakes76]

Marking

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate design and implementation
Good spacing and comments
Header blocks

Recognition Problem

Solves problem
Driver Script present, predict file no extension -1
File structure not present, code needs won folder -2
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting minimal -1
No Data leakage
Difficulty: Hard

Commit Log

Meaningful commit messages
Progressive commits used

Documentation

ReadMe acceptable, no usage -1
Model/technical explanation
Good Description and Comments
Markdown used and PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in InCorrect Branch) -2
Feedback required, move code to own folder and use correct branch -2
Request Description minimal -1

[shakes76]

Feedback marks possible +2 if the requested changes are made (see above).

[wangzhaomxy]

No feedback attempt and no feedback marks granted.