catch lstat ENOENT to set destDir when using includesPath#47
Open
hollanddd wants to merge 1 commit intoserverless:masterfrom
Open
catch lstat ENOENT to set destDir when using includesPath#47hollanddd wants to merge 1 commit intoserverless:masterfrom
hollanddd wants to merge 1 commit intoserverless:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not convinced that this is the most elegant approach and am open to further discussion. As it stands the ternary operator will exit when
fs.lstatSync()throws the ENOENT error. In that case I set thedestDirto the optimized path plus the included path. I triedfs.lstat()but I ran into async issues there. I also entertained the idea of usingfs.exists()as it would have been a small addition to the already existing ternary operator. However, it's deprecated causing me to look for a new solution.