perf: use swar to skip whitespace#1314
Open
cyruspyre wants to merge 2 commits intoserde-rs:masterfrom
Open
Conversation
Author
|
I was somewhat able to reduce the slow down when there is no whitespace by replacing the code in There was swar code duplication and a call to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if you will accept it but, using swar to skip whitespace improves performance when skipping over large amount of whitespaces. But also degrades, when there is none at all. I tried to avoid the degradation but was unable to do it. I've tried checking for 1-2 chars outside the loop but the generated asm was doing that already and manually doing it somehow made it even worse.
Running with
-C target-cpu=nativejust made it use YMM register to perform the same operations...