fix for filenames with spaces: decode key names from utf8#21
Closed
etiennesky wants to merge 1 commit intoseedifferently:masterfrom
Closed
fix for filenames with spaces: decode key names from utf8#21etiennesky wants to merge 1 commit intoseedifferently:masterfrom
etiennesky wants to merge 1 commit intoseedifferently:masterfrom
Conversation
Author
|
closing this pull request, #18 is better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this simple fix addresses a really annoying bug: in linux (perhaps Windows also), when a file name contains spaces, it is uploaded every time. The cause of this bug is that the s3 keys are returned as unicode, whereas the local filenames are str objects.