Open
Conversation
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
Member
|
The default should be True. The RFC has it on True by default for the kernel for good reasons -- the FPU was enabled by default before and you will get hangs/crashes if you do not force the compiler to avoid FPU/SIMD instructions. |
Author
|
Apologies, right - the FPU will be enabled by default and only disabled if one explicitly specifies |
midnightveil
suggested changes
Dec 11, 2025
| fault_ep, | ||
| )?; | ||
|
|
||
| tcb.tcb_set_flags( |
There was a problem hiding this comment.
given this is supposed to take a bit flags it should probably be explicitly referencing the sel4_tcbflag_fpudisabled instead of just assuming fpu is bit 0 and Boolean conversion.
Author
There was a problem hiding this comment.
True, makes senses to be future compliant.
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for PDs to specify the
fpuflag to explicitly disable the FPU usage in them. By default it's set totrue.